comparator icon indicating copy to clipboard operation
comparator copied to clipboard

Support multidimensional and associative arrays when canonicalize

Open alexndlm opened this issue 2 years ago • 7 comments

Fix:

  • https://github.com/sebastianbergmann/comparator/issues/77

Relates:

  • https://github.com/sebastianbergmann/phpunit/issues/4455
  • https://github.com/sebastianbergmann/comparator/issues/44

alexndlm avatar Aug 14 '23 09:08 alexndlm

Would you please fix CI or suggest how to do this?

alexndlm avatar Aug 14 '23 09:08 alexndlm

Would you please fix CI or suggest how to do this?

Please rebase against main.

sebastianbergmann avatar Aug 14 '23 09:08 sebastianbergmann

Thanks. Done.

alexndlm avatar Aug 14 '23 10:08 alexndlm

Codecov Report

Merging #108 (501f687) into main (a261237) will increase coverage by 0.05%. Report is 20 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 501f687 differs from pull request most recent head bc39224. Consider uploading reports for the commit bc39224 to get more accurate results

@@             Coverage Diff              @@
##               main     #108      +/-   ##
============================================
+ Coverage     98.14%   98.20%   +0.05%     
- Complexity      118      124       +6     
============================================
  Files            14       14              
  Lines           324      334      +10     
============================================
+ Hits            318      328      +10     
  Misses            6        6              
Files Coverage Δ
src/ArrayComparator.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 14 '23 12:08 codecov[bot]

@cosmastech would you be so nice and review this PR and if its ok merge it? Would be really neat to have this fix in. thanks in advance

senaria avatar May 02 '24 14:05 senaria

@cosmastech would you be so nice and review this PR and if its ok merge it? Would be really neat to have this fix in. thanks in advance

I don't see an issue with the implementation, however, I think it still needs reviewed and merged by the maintainer.

cosmastech avatar May 02 '24 14:05 cosmastech

Thanks @cosmastech for answering so fast back.

@sebastianbergmann would you be so nice and merge it in if it is ok to you. Thanks alot

senaria avatar May 06 '24 13:05 senaria