fuzzywuzzy icon indicating copy to clipboard operation
fuzzywuzzy copied to clipboard

Fix some code quality issues

Open pnijhara opened this issue 5 years ago • 2 comments

  • Remove unnecessary comprehension
  • Remove unused variables

Find the other issues found here - https://deepsource.io/gh/pnijhara/fuzzywuzzy/issues/?category=all

This PR also adds .deepsource.toml configuration file to run DeepSource analysis on the repo with. Upon enabling DeepSource, the analysis will run on every PR and commit to detect 560+ types of issues in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.

To enable DeepSource analysis after merging this PR, please follow these steps:

  1. Signup on DeepSource with your GitHub account and grant access to this repo.
  2. Activate analysis on this repo here.

You can also look at the docs for more details. Do let me know if I can be of any help!

pnijhara avatar Apr 13 '20 12:04 pnijhara

Following https://github.com/seatgeek/fuzzywuzzy/pull/254 in February I doubt that the repository owners want to adopt deepsource ;)

maxbachmann avatar Apr 15 '20 19:04 maxbachmann

Found it a little late. Still can wait for repository owner for his valuable suggestion.

pnijhara avatar Apr 17 '20 07:04 pnijhara