Sean Mullan

Is there any value in keeping `SubjectDelegationPermission` after this change? If so, I would mark that API deprecated for removal, so that it can be removed in the next release...

Are there remaining tests that test the JMX fine grained permissions feature w/o depending on subject delegation?

> > Is there any value in keeping `SubjectDelegationPermission` after this change? If so, I would mark that API deprecated for removal, so that it can be removed in the...

As part of this API, we should also add a KEY_DERIVATION enum to the `java.security.CryptoPrimitive` class.

In the release note, it says "To ensure interoperability with SunJCE and Kerberos which uses the CS3 variant (see https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38a-add.pdf, a new SunPKCS11 provider configuration attribute named "cipherTextStealingVariant" is introduced...

It might just be me, but the word "sample" is too related to programming examples that it makes this feel like something that users may not take seriously. But I...

A few other comments/questions: Does this need a CSR since you are adding new property files? Are there any tests to ensure the property files are working correctly? Also, how...

> > Also, how does one try out these property files? Is there a system property that needs to be set? Can you add more details to the RN on...

Please hold off on integrating until someone from the Security group reviews this. Also, you should change the Assignee of the issue to yourself.

Would you consider also fixing https://bugs.openjdk.org/browse/JDK-8340312 as part of this? There are no calls to `SSLLogger.finer()` so it is unused code at the moment. Consider removing `finer()` and changing `finest()`...