Sean McManus

Results 1058 comments of Sean McManus

@akbyrd Did you repro this with 1.22.8 too? That has some potential fixes. It appears to be stuck from `(invoked) cpptools/didChangeCppProperties`

@akbyrd Yeah, I think it's processing the compile_commands command. This was improved with https://github.com/microsoft/vscode-cpptools/issues/10029. How many compile commands entries are there? How long are you seeing it take to finish...

@akbyrd Was the 100k updateTrustedCompilersList with 1.22.8? That was supposed to be fixed by https://github.com/microsoft/vscode-cpptools/issues/12078 . I think we only tested performance for a 10k compile_commands and 70-110k might require...

@akbyrd If you can try with 1.22.8 (which we're planning to release soon as 1.22.9 non-pre-release) and let us know if (how much) it is faster that would help. But...

@akbyrd Okay, sounds like "no improvement".

@akbyrd Also, FYI, the Visual Studio 2022 product has specific optimizations and functionality for Unreal Engine that don't exist in VS Code, so you may want to consider that instead.

@Finn-Else-McCormick-Abertay Your compile_commands.json is incorrect. It uses `"-IC:/msys64/ucrt64/bin/../include"` -- it should be using `"-isystemC:/msys64/ucrt64/bin/../include"` -- can you make that change?

@Finn-Else-McCormick-Abertay Also, do you know the source of that compile_commands.json? There could be a bug with the generator.

@Finn-Else-McCormick-Abertay Actually, the compile_commands.json probably should not have the `"-IC:/msys64/ucrt64/bin/../include"` at all, since it should be provided by the compiler itself (as -isystem).

@Finn-Else-McCormick-Abertay But it's a regression bug on our part too and it doesn't match how the compiler behaves (i.e. the -isystem include from the compiler (or elsewhere) should be preserved...