[Bug-fix doc] Fix missing default values in code and doc, plus remove duplicate batch_size in a tutorial
This PR fixes:
- some missing default values in a tabular
CTGANmodule. - some missing default values in the tutorial of those same models and cleans duplicate information for
batch_sizeinTVAE. - an error in the doc for the
l2scaleparam type (what int when it is in fact a float). - the
Dictionarytypo in the doc.
Codecov Report
Merging #784 (221acb0) into master (8d3d847) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 67.88% 67.88%
=======================================
Files 38 38
Lines 2868 2868
=======================================
Hits 1947 1947
Misses 921 921
| Impacted Files | Coverage Δ | |
|---|---|---|
| sdv/metadata/table.py | 76.80% <ø> (ø) |
|
| sdv/tabular/base.py | 81.49% <ø> (ø) |
|
| sdv/tabular/copulagan.py | 89.28% <ø> (ø) |
|
| sdv/tabular/copulas.py | 88.07% <ø> (ø) |
|
| sdv/tabular/ctgan.py | 77.77% <ø> (ø) |
|
| sdv/timeseries/base.py | 0.00% <ø> (ø) |
|
| sdv/timeseries/deepecho.py | 0.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8d3d847...221acb0. Read the comment docs.
Hi @davebulaval, thanks for your contribution request. We have recently released the new, SDV 1.0 (Beta!), which contains a separate, dedicated docs site as well as demo notebooks. The codebase has also changed (visible on our SDV 1.0 branch). Given this, I'm closing off the PR as obsolete.
However, if you do notice any issues in the new documentation or tutorials, please feel free to file a new issue!