SDV
SDV copied to clipboard
Changing conditions in ScalarRange for is_datetime
I suggest updating the condition that checks for datetime types in ScalarRange.
This resulted in an exception when the range values could be interpreted as dates (e.g., 1900, 2000) even though the column type is int.
Therefore I suggest raisin the exception only when the column is a datetime and not both low/high values of the range are datetime.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.62%. Comparing base (
80c01c1) to head (c95fb5a). Report is 151 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #2150 +/- ##
==========================================
+ Coverage 97.35% 97.62% +0.27%
==========================================
Files 51 57 +6
Lines 4869 5773 +904
==========================================
+ Hits 4740 5636 +896
- Misses 129 137 +8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello, would you have any update or comment on this PR? the changes are relatively small.