SDV icon indicating copy to clipboard operation
SDV copied to clipboard

Changing conditions in ScalarRange for is_datetime

Open Deathn0t opened this issue 1 year ago • 2 comments

I suggest updating the condition that checks for datetime types in ScalarRange.

This resulted in an exception when the range values could be interpreted as dates (e.g., 1900, 2000) even though the column type is int.

Therefore I suggest raisin the exception only when the column is a datetime and not both low/high values of the range are datetime.

Deathn0t avatar Jul 26 '24 08:07 Deathn0t

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.62%. Comparing base (80c01c1) to head (c95fb5a). Report is 151 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
+ Coverage   97.35%   97.62%   +0.27%     
==========================================
  Files          51       57       +6     
  Lines        4869     5773     +904     
==========================================
+ Hits         4740     5636     +896     
- Misses        129      137       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 26 '24 08:07 codecov-commenter

Hello, would you have any update or comment on this PR? the changes are relatively small.

Deathn0t avatar Aug 12 '24 09:08 Deathn0t