jinora icon indicating copy to clipboard operation
jinora copied to clipboard

Replace slack-utils with the slack package

Open captn3m0 opened this issue 6 years ago • 10 comments

The slack-utils package was written when there weren't many good clients for Slack available. However:

  • Jinora is the only app using it
  • It hasn't been maintained in quite some time
  • There are known security issues with the dependencies it is using

I've been trying to do a new release, but mocha is causing some issues with tests that I don't want to bypass: https://github.com/captn3m0/slack-utils/pull/7

But even then, this would be a stop-gap measure, since slack-utils relies on Slack Legacy Tokens and not the new API. Using the new API would also give Jinora some super-powers like supporting multiple organizations easily with one-click installs.

captn3m0 avatar May 26 '19 13:05 captn3m0

Can you post the link to the slack package you're talking about?

vrongmeal avatar Jun 07 '19 16:06 vrongmeal

captn3m0/slack-utils on GitHub, slack-utils on NPM.

On 07-Jun-2019, at 22:13, Vaibhav [email protected] wrote:

Can you link me to the slack package you're talking about?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

captn3m0 avatar Jun 07 '19 16:06 captn3m0

Yeah... So I was asking about the package we want to replace slack-utils with.

vrongmeal avatar Jun 07 '19 17:06 vrongmeal

Sorry, was on mobile.

https://www.npmjs.com/package/slack seems to support everything

captn3m0 avatar Jun 07 '19 17:06 captn3m0

Thanks! I'll take a look at it :)

vrongmeal avatar Jun 07 '19 17:06 vrongmeal

@vrongmeal Any update on this?

captn3m0 avatar Jun 25 '19 10:06 captn3m0

Hi! Sorry I've been a bit busy. Totally forgot about this. I'll ask someone else if anyone is interested in changing the dependency.

vrongmeal avatar Jun 25 '19 18:06 vrongmeal

Please do. I'm planning to delete the npm package by month end (31st July)

captn3m0 avatar Jul 01 '19 12:07 captn3m0

@vrongmeal Is someone picking this up?

captn3m0 avatar Jul 22 '19 07:07 captn3m0

Yeah. @AyanChoudhary has taken this up.

vrongmeal avatar Jul 23 '19 13:07 vrongmeal