gps icon indicating copy to clipboard operation
gps copied to clipboard

Add logic to disallow import cycles

Open sdboyer opened this issue 9 years ago • 1 comments
trafficstars

There's a spot just waiting to do it in the checkProject() and checkPackage() methods.

For now, it's probably fine to use an offline algorithm (e.g., Tarjan SCC) to find cycles. That gives us linear time in the number of packages and dependencies. Brief searches suggest that there's probably a sublinear incremental cycle discovery algorithm out there that we can swap in later.

sdboyer avatar Jul 19 '16 19:07 sdboyer

This issue was moved to golang/dep#439

fabulous-gopher avatar Apr 21 '17 14:04 fabulous-gopher