gps icon indicating copy to clipboard operation
gps copied to clipboard

Published 20 hours ago • verified publisher icon sdboyer

GPS needs to respect flat packages

Open krisnova opened this issue 8 years ago • 6 comments

Right now dep was trying to find versions for a bmi if it was a root level package.. This PR bypasses the BMI in this case so we don't fail trying to check on ourselves

Closes https://github.com/golang/dep/issues/270

Also fixes indentation in tracer

krisnova avatar Mar 07 '17 22:03 krisnova

@sdboyer

I am going to play with the tests in a little, but wanted to push this up so you could see where I was at.. Thoughts? I suppose this is a work in progress PR 😛

krisnova avatar Mar 07 '17 22:03 krisnova

(I'm very excited that someone else is poking at the actual guts of the algorithm 🎉 🎉 🎊 !!)

Hmm...let's start with a definition for "flat package" - do you mean a project containing only the single package at the project root?

sdboyer avatar Mar 08 '17 02:03 sdboyer

Ah yes, so please forgive my vernacular as I am still learning all of your GPS terms.. but I will at least be consistent and will learn quickly.

So to me a flat package is a Go package that contains no other packages inside of it. So yes, a single package, at the root, no other nested packages. With of course typewriter being a great example.

krisnova avatar Mar 08 '17 02:03 krisnova

oh no worries, of course, there's a lot of verbiage in here. bimodalIdentifier itself isn't exactly great - though i think the crowning glory of unhelpfully stupid names is completeDep :P

sdboyer avatar Mar 08 '17 03:03 sdboyer

I can't remember if this was still needed, or if the surface problem in dep was fixed by something else...

sdboyer avatar Apr 13 '17 12:04 sdboyer

Thanks for the ping @sdboyer - I completely forgot about this PR...

I am not sure either.. looks like the issue is still open - I will ping you in slack and we can figure it out

krisnova avatar Apr 14 '17 00:04 krisnova