spatialdata-plot icon indicating copy to clipboard operation
spatialdata-plot copied to clipboard

spring cleaning: incorrect images in visual tests

Open timtreis opened this issue 1 year ago • 0 comments

  • [x] Image 1 (fixed by https://github.com/scverse/spatialdata-plot/pull/287) image ~Background is taken as shape, should be white. White dots should probably be C~ https://github.com/scverse/spatialdata-plot/pull/323 and https://github.com/scverse/spatialdata-plot/pull/334

  • [ ] Image 2 image ~Probably same as image 1~

  • [ ] Image 3 image Why is bg black? Not black on local, only on runner?

  • [ ] Image 4 image Why is bg black? Not black on local, only on runner?

  • [ ] Image 5 image Why are some of the colors different? Non-deterministic return order of colors?

  • [ ] Image 6 image ~Did we change the default color? Why is legend gone?~ https://github.com/scverse/spatialdata-plot/pull/344

  • [ ] Image 7 image Why is there an extra triangle? Filter not working?

Image 8 image Why are there two extra triangles?

Image 9 image ~MultiPolygon broken~ https://github.com/scverse/spatialdata-plot/pull/334, extent broken (https://github.com/scverse/spatialdata/issues/693)

timtreis avatar May 16 '24 21:05 timtreis