spatialdata-io icon indicating copy to clipboard operation
spatialdata-io copied to clipboard

[WIP] add macsima reader

Open berombau opened this issue 1 year ago • 3 comments

This tries to solve #155.

Lung_adc_demo

from spatialdata_io import macsima
sdata = macsima('./Lung_adc_demo', subset=1000)
sdata
SpatialData object with:
└── Images
      └── 'Lung_adc_demo': MultiscaleSpatialImage[cyx] (116, 1000, 1000), (116, 500, 500)
with coordinate systems:
▸ 'microns', with elements:
        Lung_adc_demo (Images)

Sill need to check on Liver cell atlas data and the parsing issue of the channel names.

berombau avatar Jun 11 '24 15:06 berombau

Codecov Report

:x: Patch coverage is 21.47239% with 128 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 34.86%. Comparing base (cff4896) to head (e73cb1d). :warning: Report is 227 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/macsima.py 21.27% 74 Missing :warning:
src/spatialdata_io/readers/_utils/_utils.py 14.28% 54 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #156       +/-   ##
===========================================
- Coverage   45.50%   34.86%   -10.65%     
===========================================
  Files          22       23        +1     
  Lines        2149     2312      +163     
===========================================
- Hits          978      806      -172     
- Misses       1171     1506      +335     
Files with missing lines Coverage Δ
src/spatialdata_io/__init__.py 100.00% <100.00%> (ø)
src/spatialdata_io/_constants/_constants.py 100.00% <100.00%> (ø)
src/spatialdata_io/readers/_utils/_utils.py 19.35% <14.28%> (-23.27%) :arrow_down:
src/spatialdata_io/readers/macsima.py 21.27% <21.27%> (ø)

... and 4 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 11 '24 15:06 codecov-commenter

@berombau excited to see this new reader! What the status/task list for this PR? Thanks for the info.

LucaMarconato avatar Jun 24 '24 16:06 LucaMarconato

It's on my to-do list of things to wrap up by the end of next week before I go on holiday. I would want to change the code a little so it can also run on multiple folders. It should also work on a raw data output folder with some modifications from the other scripts. There is also a small bug in the channel parsing still.

berombau avatar Jun 25 '24 14:06 berombau

Close in favor of https://github.com/scverse/spatialdata-io/pull/224

berombau avatar Oct 22 '24 10:10 berombau