scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

Adding model with cycle consistency and VampPrior

Open Hrovatin opened this issue 1 year ago • 10 comments

Closes https://github.com/scverse/scvi-tools/issues/2383

Hrovatin avatar Jan 19 '24 09:01 Hrovatin

Codecov Report

Attention: Patch coverage is 90.25735% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 89.40%. Comparing base (6062656) to head (8c25dba). Report is 1 commits behind head on main.

:exclamation: Current head 8c25dba differs from pull request most recent head 54f5734. Consider uploading reports for the commit 54f5734 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
- Coverage   89.90%   89.40%   -0.50%     
==========================================
  Files         154      161       +7     
  Lines       12629    13172     +543     
==========================================
+ Hits        11354    11777     +423     
- Misses       1275     1395     +120     
Files Coverage Δ
scvi/external/__init__.py 100.00% <100.00%> (ø)
scvi/external/sysvi/__init__.py 100.00% <100.00%> (ø)
scvi/external/sysvi/_module.py 97.67% <97.67%> (ø)
scvi/external/sysvi/_priors.py 93.18% <93.18%> (ø)
scvi/external/sysvi/_utils.py 93.75% <93.75%> (ø)
scvi/external/sysvi/_trainingplans.py 91.39% <91.39%> (ø)
scvi/external/sysvi/_model.py 92.68% <92.68%> (ø)
scvi/external/sysvi/_base_components.py 73.52% <73.52%> (ø)

... and 4 files with indirect coverage changes

codecov[bot] avatar Jan 19 '24 09:01 codecov[bot]

I added changes and adapted tutorial accrordingly

Hrovatin avatar Jan 21 '24 18:01 Hrovatin

Thanks for addressing the comments! I'll take another pass at it soon.

martinkim0 avatar Jan 22 '24 06:01 martinkim0

@martinkim0 thank you for looking at it again - I added the changes as requested

Hrovatin avatar Feb 07 '24 12:02 Hrovatin

Sorry for the delay in reviewing this - hopefully taking a last pass this week and we get this merged!

martinkim0 avatar Mar 11 '24 17:03 martinkim0