scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

Model request: non-negative spatial factorization (NSF)

Open aribenjamin opened this issue 2 years ago • 4 comments

Is anyone currently working on implementing NSF? It's a nice probabilistic method designed with spatial transcriptomics in mind. https://www.nature.com/articles/s41592-022-01687-w

It'd be nice to work with this here, within scvi-tools. The authors' implementation (@ https://github.com/willtownes/nsf-paper) is a little hard to parse and implemented with Tensorflow as a backend (which I don't work in).

aribenjamin avatar Jan 18 '23 19:01 aribenjamin

I think this would be a nice addition. It might be easiest to implement using tensorflow probability and jax as the kernel functions should be the same; unless of course it's also straightforward in pytorch. Are you willing to contribute this?

adamgayoso avatar Jan 18 '23 19:01 adamgayoso

Yes, I'm happy to go for it. It'd be good practice contributing. I can't guarantee any timeline, though, so if someone wants this sooner please ping me.

aribenjamin avatar Jan 20 '23 18:01 aribenjamin

Looking into this more, it should be possible with just PyTorch, or just jax+numpyro (which we already depend on), without the introduction of tensorflow probability. @martinkim0 do you want to try this model? It looks both fairly straightforward and fun.

adamgayoso avatar Feb 05 '23 18:02 adamgayoso

fyi I have back-burnered this to the point of inaction. If you want to work on this, know that I'm not working in parallel. I'll update this when and if I begin.

aribenjamin avatar May 03 '23 15:05 aribenjamin