scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

Finalize scBasset

Open adamgayoso opened this issue 2 years ago • 4 comments

  • [x] Verify that all parameters are being initialized equivalently, alter the ones used here if needed
  • [x] Add more content to the tutorial that reproduces their results, allowing us to have some form of reproducibility
  • [ ] Complete the user guide

adamgayoso avatar Jan 09 '23 01:01 adamgayoso

@adamgayoso Thoughts on adding a batch correction portion to the tutorial using the buenrostro dataset from the original manuscript?

martinkim0 avatar Jan 11 '23 01:01 martinkim0

I think we should and the maybe use scib metrics on it

adamgayoso avatar Jan 11 '23 20:01 adamgayoso

I'm wondering whether we should add an option in setup_anndata to indicate whether the data is transposed already or not, where if it's not transposed, we do it on our end. It might be confusing for users when you have to bdata = adata.transpose() but then the latent space is saved back into the original adata.

martinkim0 avatar Jan 12 '23 20:01 martinkim0

I agree this needs improvement. I'm a fan of what you see is what you get and it would be confusing if model.adata was transposed

adamgayoso avatar Jan 12 '23 21:01 adamgayoso