scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

DestVI changed l1 loss. Expected proportions

Open canergen opened this issue 3 years ago • 3 comments

Uses proportions computed in other deconvolution method to infer cell activation state of those cells. Application activation for e.g. Cell2Location results. L1 loss changed. Still in discussion. Optional obsm field.

canergen avatar Jul 03 '22 23:07 canergen

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (638745a) 89.18% compared to head (8aab83f) 88.94%. Report is 1 commits behind head on main.

Files Patch % Lines
scvi/module/_mrdeconv.py 63.26% 18 Missing :warning:
scvi/model/_destvi.py 81.81% 4 Missing :warning:
scvi/data/fields/_arraylike_field.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   89.18%   88.94%   -0.25%     
==========================================
  Files         152      152              
  Lines       12482    12536      +54     
==========================================
+ Hits        11132    11150      +18     
- Misses       1350     1386      +36     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 04 '22 01:07 codecov[bot]

@cane11 any reason to keep this open?

adamgayoso avatar Mar 24 '23 21:03 adamgayoso

@martinkim0 It's the version of destVI we are using for Curio data (other sparsity regularization). Can you have a pass?

canergen avatar Dec 08 '23 05:12 canergen