scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

Allow additional arguments for SCVI encoder and decoder

Open Koncopd opened this issue 3 years ago • 2 comments
trafficstars

related to https://github.com/scverse/scvi-tools/issues/1510

Allows to do this set_activation = dict(activation_fn=torch.nn.Softplus) vae = scvi.model.SCVI(adata, encoder_kwargs=set_activation, decoder_kwargs=set_activation)

Koncopd avatar Apr 19 '22 14:04 Koncopd

Codecov Report

Merging #1511 (5b4786e) into master (5496b99) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1511   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files         112      112           
  Lines        8829     8829           
=======================================
  Hits         8024     8024           
  Misses        805      805           
Impacted Files Coverage Δ
scvi/module/_vae.py 94.42% <ø> (ø)
scvi/nn/_base_components.py 96.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5496b99...5b4786e. Read the comment docs.

codecov[bot] avatar Apr 19 '22 14:04 codecov[bot]

Thx, i will make the changes.

Koncopd avatar Apr 28 '22 09:04 Koncopd

Hey, I would also be interested in trying out different activation functions. I guess this PR still isn't in the code base, is that right? Any chance it could be...? :D

Thanks!

wmacnair avatar Mar 08 '23 10:03 wmacnair

I'm happy to get something here in. Let me discuss with @martinkim0. Ideally we would have configs, but this might not be doable.

adamgayoso avatar Mar 08 '23 16:03 adamgayoso