napari-spatialdata icon indicating copy to clipboard operation
napari-spatialdata copied to clipboard

Add notebook testing capabilites in Interactive

Open rahulbshrestha opened this issue 2 years ago • 2 comments

Related PR: https://github.com/scverse/spatialdata-notebooks/pull/46

rahulbshrestha avatar Aug 23 '23 11:08 rahulbshrestha

I merged the other PR, thanks for the contribution. Please pull from main before continuing.

LucaMarconato avatar Aug 23 '23 15:08 LucaMarconato

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (f889c52) 75.77% compared to head (928b718) 74.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   75.77%   74.58%   -1.19%     
==========================================
  Files          16       16              
  Lines        1717     1759      +42     
==========================================
+ Hits         1301     1312      +11     
- Misses        416      447      +31     
Files Coverage Δ
src/napari_spatialdata/utils/_test_utils.py 69.04% <16.66%> (-20.96%) :arrow_down:
src/napari_spatialdata/_interactive.py 60.60% <33.33%> (-25.51%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 27 '23 11:08 codecov-commenter

I think this can actually be closed as I don't think it will be worked on further

giovp avatar Jul 22 '24 11:07 giovp

ok, I would say it would be good to add tests for notebooks though, but low priority for now.

melonora avatar Jul 22 '24 11:07 melonora