scummvm icon indicating copy to clipboard operation
scummvm copied to clipboard

Published 20 hours ago • verified publisher icon scummvm

NOTTESTED: DISCORD: load discord library dynamically

Open phcoder opened this issue 2 years ago • 9 comments

discord-rpc.dll has higher OS requrements than scummvm itself. Allow its loading to be skipped. Do the same on other platforms with discord for simplicity and possibly a small benefit.

phcoder avatar Jan 17 '23 22:01 phcoder

Just curious, what is the OS requirement that discord-rpc.dll has that scummvm.exe doesn't? We don't configure the Win9x or XP builds to include discord, and the last release of discord-rpc.dll was in 2018, and the library has been deprecated. As far as I know, discord-rpc.dll works on Windows 7, so is it a Vista problem?

I have no objection to linking to discord dynamically, but I'm interested in the specific incompatibility this fixes.

sluicebox avatar Jan 20 '23 23:01 sluicebox

In fact I just noticed that in the buildbot I compiled discord-rpc statically. This change would then break the buildbot.

lephilousophe avatar Jan 21 '23 18:01 lephilousophe

Same for the Win32 release buildbot - I just noticed that the discord-rpc.dll I ship with the builds is not necessary at all.

lotharsm avatar Jan 21 '23 19:01 lotharsm

As far as I know, discord-rpc.dll works on Windows 7, so is it a Vista problem?

discord-rpc.dll requires Vista or higher - that's why I exclude it from the Windows XP builds.

lotharsm avatar Jan 21 '23 20:01 lotharsm

Do you know what is missing? Does this mean that building statically with discord-rpc makes the binary incompatible with XP?

lephilousophe avatar Jan 22 '23 09:01 lephilousophe

IIRC, the Discord stuff was one of the main reasons why I did started splitting the Windows XP builds from the "general" variant. The issue was that with Discord support enabled, it failed to run on Windows XP. I don't remember if I ever tried to build it dynamically though - but I am 99,9% confident that it breaks XP when building statically.

For this reason, I disable Discord support entirely on Windows XP.

lotharsm avatar Jan 22 '23 10:01 lotharsm

discord/discord-rpc@b0e31a9e25c556830b3d28319ff994ee3773cf4c added Windows XP support. Maybe that statically link with a mingw version of discord-rpc (what we do) makes it work on XP?

lephilousophe avatar Jan 22 '23 10:01 lephilousophe

Uh, then I need to revisit this after the release (my toolchain is due for an update anyways) - I thought I was using the very latest version already.

lotharsm avatar Jan 22 '23 11:01 lotharsm

What is the status of this PR? Is this change still needed, now that Windows XP is supported in the Discord code?

bluegr avatar Sep 04 '23 07:09 bluegr

Closing this

sev- avatar Apr 24 '24 22:04 sev-