Scribe-iOS icon indicating copy to clipboard operation
Scribe-iOS copied to clipboard

[iPad] Wrong popup for some keys on larger iPad models

Open christianbilodeau opened this issue 1 year ago • 3 comments
trafficstars

Terms

Behavior

Some characters should be considered to be "left" or "right" key characters on larger iPad models (see xInterfaceVariables.swift files)

For example, this \ should show a "left" popup:

Screenshot 2024-10-01 at 15 20 45

And this * should show a "right" popup:

Screenshot 2024-10-01 at 15 21 11

Device type

iPad

Versions

iOS 17.5.1 & Scribe 3.1.1

christianbilodeau avatar Oct 01 '24 14:10 christianbilodeau

I can tackle this one

christianbilodeau avatar Oct 01 '24 14:10 christianbilodeau

PR opened here. Doing the changes I uncovered a separate issue about repeating keys :)

christianbilodeau avatar Oct 02 '24 08:10 christianbilodeau

Thanks so much for all the issues, @christianbilodeau! 🚀 Looking forward to the review :)

andrewtavis avatar Oct 02 '24 08:10 andrewtavis

Closed via #511 🚀 Thanks so much for a great contribution, @christianbilodeau! Hope we'll be able to work with you again 😊 Please feel free to open issues anytime!

andrewtavis avatar Nov 12 '24 23:11 andrewtavis