Scribe-iOS
Scribe-iOS copied to clipboard
scribe-org
Switch all language references in code to ISO-2 codes
Terms
- [X] I have searched open and closed feature requests
- [X] I agree to follow Scribe-iOS' Code of Conduct
Description
This issue is a simple one of renaming variables. As of now throughout the codebase we're naming variables based on the language and the ISO-2 code of the language, so like EnglishVarName and enVarName. We should rather use ISO-2 codes throughout the codebase so it's consistent.
As a part of this, we should also organize some of the new files within the repo, which can be done by maintainers in the PR that comes from this :)
Contribution
Happy to support with renaming and help move files around once the PR is up! 😊
Note that we'll still have the Language names as directories names within the language keyboards directory, but the code references themselves should just be the two letter codes :)
Hi @andrewtavis I'm looking for a good first issue to contribute to. Could I check for this one ?
Would be great, @helocordi! Please let us know if you need any support :)
Hope it's ok if we reassign, @henrikth93! Lots else you can get to :) Let's be in touch during the sync!
Hope it's ok if we reassign, @henrikth93! Lots else you can get to :) Let's be in touch during the sync!
That is absolutely fine! When it comes to issues I feel like I have hoarded a little hehe.
Would be great, @helocordi! Please let us know if you need any support :)
Thank you, I'll take a look then
Hi @andrewtavis ! Is this issue resolved? I'm looking to make my first-ever contribution.
@helocordi is working on this right now, @ThousandYearGrind :) Please let us know if there's another issue that you'd have interest in 😊
Hi @andrewtavis ! Is this issue resolved? I'm looking to make my first-ever contribution.
Hello @ThousandYearGrind and welcome! I am assigned to an issue, which maybe you want to take over? https://github.com/scribe-org/Scribe-Android/issues/149
It is Android-related, is that something you want to do?
Hi @henrikth93 , and thank you for your offer. I would to give the issue a try!
Hi @henrikth93 , and thank you for your offer. I would to give the issue a try!
Nice, do you know how to assign yourself?
Hi @henrikth93 , and thank you for your offer. I would to give the issue a try!
Nice, do you know how to assign yourself?
No, @henrikth93, how do I do that?
Can you click the link to the issue, and just write a comment on that issue, like you did with that one? Maybe I can assign you from there.
Den ons 11 dec. 2024 kl 22:40 skrev Patrick Dong @.***>:
Hi @henrikth93 https://github.com/henrikth93 , and thank you for your offer. I would to give the issue a try!
Nice, do you know how to assign yourself?
No, how do I do that?
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-iOS/issues/494#issuecomment-2537248766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZN5AUXQUZOPN6P5ELF3VAT2FCWLXAVCNFSM6AAAAABNBQ6KZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGI2DQNZWGY . You are receiving this because you were mentioned.Message ID: @.***>
A bit confused by the conversation above. Let me know which issue we're talking about here and I can assign :)
A bit confused by the conversation above. Let me know which issue we're talking about here and I can assign :)
@andrewtavis https://github.com/scribe-org/Scribe-Android/issues/149
Closed by #524 🚀 Thank you for the help and the great communication here, @helocordi! 😊