SwiftLint: Fix todo throughout codebase

[andrewtavis]

trafficstars

Terms

• [X] I have searched open and closed feature requests
• [X] I agree to follow Scribe-iOS' Code of Conduct

Description

Work for this issue would remove todo as a disabled rule from .swiftlint.yml and fix all errors for it in the codebase.

Docs for todo are here: https://realm.github.io/SwiftLint/todo.html

We'd know that this is successful if our SwiftLint pull request workflow passes on the pull request for the change 🚀

Contribution

I'll work on this one by making issues to account for all todos that include information on what's to be done and the location of the original todo 😊

[christianbilodeau]

Hi, I looked into this one, just to confirm, all the TODOs are of the format:

add < key > to rightKeyChar if the keyboard has 4 rows

I'm assuming "4 rows" refers to the "floating keyboard" feature on iPad, which allows the user to minimise the keyboard and move it around the screen? It's the only keyboard format where I've seen the need for the correct popup on right key characters.

Thanks!

[andrewtavis]

Hey @christianbilodeau 👋 I'm thinking four rows is actually something to do with whether the numbers row is present or not, actually. Thanks for your consideration of this! Would be great to get some support making these issues and getting rid of the todos :)

[christianbilodeau]

Hello again @andrewtavis, the add "p" to rightKeyChar if the keyboard has 4 rows comments might be non-issues, as seen at least on my iPad mini iOS 18 simulator. The "p" key doesn't appear at the very right of the screen and therefore the current popup makes sense as it is (it appears to be cropped at the top, but that's a different issue):

However, I did notice some keys having the wrong popup when the keyboard has 5 rows (big iPad).

\ Should be left:

* Should be right:

Same issue for the symbol keys at the same positions. Happy to create issues for these if you confirm.

[andrewtavis]

This is great, @christianbilodeau! Yes, let's definitely make that issue and then we can tackle that 😊 Thanks so much for the investigations here!

[andrewtavis]

Closed by d808dcd as it looks like all the TODOs were removed in recent work. swiftlint now checks for these, and the above commit also details the testing for the codebase and notes it in the PR template.

Thanks much for the discussion here, @christianbilodeau! 😊