Scribe-Data icon indicating copy to clipboard operation
Scribe-Data copied to clipboard

Add ETL for continuous tenses in the English data flow

Open wkyoshida opened this issue 2 years ago • 6 comments
trafficstars

Terms

Languages

English

Description

This issue is for adding the ETL, i.e. SPARQL queries, parsing, creating of .json/.sqlite, to include the continuous tenses for the English data. Currently, Scribe grabs the past participle to construct the different conjugations for * perfect tenses. The same could be done with the present participle to construct the different conjugations for * perfect continuous tenses.

Earlier discussion ref

Possible Wikidata QID to use: Q10345583

wkyoshida avatar Sep 09 '23 02:09 wkyoshida

I believe the work for this should roughly boil down to adding an additional block here in the query_verbs.sparql to also get the present participle and then also adding the corresponding piece here in the format_verbs.py to format/add the new data in the results.

wkyoshida avatar Feb 17 '24 23:02 wkyoshida

I would like to work on this issue.

mhmohona avatar Mar 05 '24 06:03 mhmohona

Hey @mhmohona :wave: Awesome! Thank you for the interest! Looks like you got a couple issues assigned. Let's look to get those wrapped up, and then we can get this one assigned! :rocket:

wkyoshida avatar Mar 06 '24 01:03 wkyoshida

@ikeadeoyin, would you have interest in this one?

andrewtavis avatar Mar 09 '24 14:03 andrewtavis

Yes please @andrewtavis

ikeadeoyin avatar Mar 09 '24 14:03 ikeadeoyin

Great, @ikeadeoyin! Let @wkyoshida or I know if you need some help here :)

andrewtavis avatar Mar 09 '24 16:03 andrewtavis

Going through old issues at the moment :) We now have continuous tenses for present, past, future and conditional in English, so this issue's good to close. Commit for it was 7573808. Thanks all!

andrewtavis avatar Aug 18 '24 17:08 andrewtavis