Scribe-Data icon indicating copy to clipboard operation
Scribe-Data copied to clipboard

Expand Italian verbs query

Open andrewtavis opened this issue 1 year ago • 2 comments
trafficstars

Terms

Description

In recent testing I realized that the Italian verb modeling has now been standardized. In the past - unlike other Latin languages - Italian had its forms in combined properties like first person singular rather than the standard of first person and singular separately. We now need to update the query to split all of the properties to their separate forms. We'll know that the query works when all the verb conjugations can be seen when running the query in the Wikidata Query Service UI.

Contribution

Happy to support as needed and review the PR when it's ready! 😊

andrewtavis avatar Oct 07 '24 21:10 andrewtavis

Hi @andrewtavis, could you assign this to me?

OkpePhillips avatar Oct 07 '24 22:10 OkpePhillips

Thanks for picking this up, @OkpePhillips! This will be key for the next Scribe-iOS update, so really appreciate your help!

andrewtavis avatar Oct 07 '24 23:10 andrewtavis

hey @andrewtavis I'd also like to work on this, @OkpePhillips can we work together on this?

VNW22 avatar Oct 14 '24 17:10 VNW22

There's only one query to work on here @VNW22, so maybe another issue would make more sense? Do you want to work on all the queries we normally do for language_data_extraction/Chinese/Mandarin? Just moved that over for you :)

andrewtavis avatar Oct 14 '24 17:10 andrewtavis

Thanks for moving the query over. I’d be happy to work on all the queries for the language_data_extraction/Chinese/Mandarin folder.

VNW22 avatar Oct 14 '24 18:10 VNW22

@andrewtavis Do I create the Issue?

VNW22 avatar Oct 14 '24 18:10 VNW22

Sure you can, @VNW22 :) Just copy the way that the other issues are made 😊

andrewtavis avatar Oct 14 '24 18:10 andrewtavis

This issue has been worked on. I made a PR @andrewtavis. Please review and let me know if the changes meet your expectations.

OkpePhillips avatar Oct 16 '24 21:10 OkpePhillips

Closed by #394 šŸš€ Thanks for the great work here, @OkpePhillips!

andrewtavis avatar Oct 16 '24 23:10 andrewtavis