Scribe-Data icon indicating copy to clipboard operation
Scribe-Data copied to clipboard

Create Korean data process queries

Open andrewtavis opened this issue 1 year ago • 11 comments

Terms

Description

This issue would look into expanding the src/scribe_data/language_data_extraction/Korean files with as much data as are possible from the current data on Wikidata. We can use code for getting data from other languages, and from there we can check Korean data on Wikidata for what conjugations are available. We can then expand the query with optional selections of certain forms as is done in other SPARQL queries. The query can be tried on the Wikidata Query Service UI during development :)

Data types to include:

  • [ ] Nouns
  • [x] Verbs
  • [ ] Adjectives
  • [x] Adverbs
  • [x] Prepositions
  • [x] Emoji keywords

Contribution

Happy to support as needed and review the code when it's been sent as a pull request! 😊

andrewtavis avatar Oct 04 '24 08:10 andrewtavis

Thank you for opening this issue! Although my understanding of this open-source project is still limited, I will do my best to contribute to this issue!

Calabi8907 avatar Oct 04 '24 08:10 Calabi8907

Happy to open it for you, @Calabi8907! Would be great if your teammates could also write in here so I have an understanding of who all is working on this :)

andrewtavis avatar Oct 04 '24 08:10 andrewtavis

I'd like to participate in this issue, too!

yerimmii avatar Oct 04 '24 08:10 yerimmii

Let's discuss in the issue who does what, and maybe one of you can open a PR for nouns and the other for verbs :)

andrewtavis avatar Oct 04 '24 08:10 andrewtavis

Running src/scribe_data/check_language_data.sparql for Korean by replacing Q9176 for the English QID, it looks like there is enough data to explore :) It's not thousands, but there are hundreds of nouns and almost 100 verbs. More data will be added later, I'm sure 😊

andrewtavis avatar Oct 04 '24 09:10 andrewtavis

I'd like to participate, too!

hydrationn avatar Oct 04 '24 10:10 hydrationn

@andrewtavis Could this issue be assigned to me?

kyw0803 avatar Oct 04 '24 10:10 kyw0803

I'd like to participate, too!

win929 avatar Oct 04 '24 11:10 win929

Checking with @Calabi8907: is everyone in this issue now part of your team? Just want to make sure. If they're not, also let me know if it's ok to assign them :)

andrewtavis avatar Oct 04 '24 11:10 andrewtavis

That's everyone on my team. no one else :)

Calabi8907 avatar Oct 04 '24 11:10 Calabi8907

Just added a list of data types that we want to include to this issue :) Let us know if any support is needed here!

andrewtavis avatar Oct 09 '24 08:10 andrewtavis

Hi @andrewtavis, Hope you are fine. Can I add Korean "Adjectives" and "Noun" queries?

Nowshin1077 avatar Oct 19 '24 14:10 Nowshin1077

Hello, I clicked the wrong thing, so I got to remove the assignment, can you add it again? This is my fault. Sorry.

win929 avatar Oct 20 '24 04:10 win929

Alright all, we just need nouns and we can close this 😊 Would be great to get this done sooner rather than later, but take your time :)

andrewtavis avatar Oct 20 '24 10:10 andrewtavis

Checking something here :) If any of you are Korean native speakers and would have interest, it'd be great to get some support with the localization issue for the applications in https://github.com/scribe-org/Scribe-i18n/issues/53 🌐

andrewtavis avatar Oct 22 '24 01:10 andrewtavis

All done here 😊 Thanks for the great work, all!

andrewtavis avatar Oct 22 '24 23:10 andrewtavis