Scribe-Data
Scribe-Data copied to clipboard
scribe-org
Expand Slovak data queries
Terms
- [X] I have searched open and closed feature requests
- [X] I agree to follow Scribe-Data's Code of Conduct
Description
This issue would look into expanding the src/scribe_data/language_data_extraction/Slovak files with as much data as are possible from the current data on Wikidata. We can use code for getting data from other languages, and from there we can check Slovak data on Wikidata for what conjugations are available. We can then expand the query with optional selections of certain forms as is done in other SPARQL queries. The query can be tried on the Wikidata Query Service UI during development :)
Data types to include:
- [x] Nouns
- [ ] Verbs
- [ ] Adjectives
- [ ] Adverbs
- [x] Prepositions
- [ ] Emoji keywords
Contribution
Happy to support via a review and also answer any questions that come up during the work 😊
Hi @andrewtavis I am looking forward to contributing.. can you assign this issue to me?
Looking forward to the contribution, @shrutikamahale! I just updated the link to the query above, btw :)
Just added a list of data types that we want to include to this issue :) Have marked those that are already done or have PRs open, and we can work on the others 😊 If the data type can't work, then we can move to the others and open up specific issues later :)
Thanks for your interest here, @Otom-obhazi! Let us know if we can do anything to assist :)
Hi @Otom-obhazi 👋 Replying to your email here :) One thing to look into is the queries that the others have made for other languages. We're working in the src/scribe_data/language_data_extraction/Slovak directory, and let's work on a new query for Slovak adjectives. We can check a query for other languages like the Italian adjectives query. Copy that query and try it out at query.wikidata.org/, and then try the same query with Q9058, which is the Wikidata identifier for Slovak, instead of Q652, the Wikidata identifier for Italian. If all works well, you can send the query for Slovak adjectives along in the src/scribe_data/language_data_extraction/Slovak directory in an adjectives directory, so the final file will be src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql.
Let me know if you have further questions!
when I run it, it shows no match record found.
On Mon, 14 Oct 2024 at 13:42, Andrew Tavis McAllister < @.***> wrote:
Hi @Otom-obhazi https://github.com/Otom-obhazi 👋 Replying to your email here :) One thing to look into is the queries that the others have made for other languages. We're working in the src/scribe_data/language_data_extraction/Slovak https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Slovak directory, and let's work on a new query for Slovak adjectives. We can check a query for other languages like the Italian adjectives query https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Italian/adjectives/query_adjectives.sparql. Copy that query and try it out at query.wikidata.org/, and then try the same query with Q9058, which is the Wikidata identifier for Slovak, instead of Q652, the Wikidata identifier for Italian. If all works well, you can send the query for Slovak adjectives along in the src/scribe_data/language_data_extraction/Slovak https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Slovak directory in an adjectives directory, so the final file will be src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql .
Let me know if you have further questions!
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-Data/issues/234#issuecomment-2411128431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQTIX2BYZHICJMYNLXPQUSLZ3O343AVCNFSM6AAAAABPKW6JBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRGEZDQNBTGE . You are receiving this because you were mentioned.Message ID: @.***>
https://github.com/Otom-obhazi/Scribe-Data/commit/d8b6040f023bf22876036edaa952f983a99933b7
please let me know if this is all good, and I would like to work on more. bitte
On Mon, 14 Oct 2024 at 15:20, Angel Osim @.***> wrote:
when I run it, it shows no match record found.
On Mon, 14 Oct 2024 at 13:42, Andrew Tavis McAllister < @.***> wrote:
Hi @Otom-obhazi https://github.com/Otom-obhazi 👋 Replying to your email here :) One thing to look into is the queries that the others have made for other languages. We're working in the src/scribe_data/language_data_extraction/Slovak https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Slovak directory, and let's work on a new query for Slovak adjectives. We can check a query for other languages like the Italian adjectives query https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Italian/adjectives/query_adjectives.sparql. Copy that query and try it out at query.wikidata.org/, and then try the same query with Q9058, which is the Wikidata identifier for Slovak, instead of Q652, the Wikidata identifier for Italian. If all works well, you can send the query for Slovak adjectives along in the src/scribe_data/language_data_extraction/Slovak https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/language_data_extraction/Slovak directory in an adjectives directory, so the final file will be src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql .
Let me know if you have further questions!
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-Data/issues/234#issuecomment-2411128431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQTIX2BYZHICJMYNLXPQUSLZ3O343AVCNFSM6AAAAABPKW6JBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRGEZDQNBTGE . You are receiving this because you were mentioned.Message ID: @.***>
You used the wrong language id in your query, @Otom-obhazi :) It needs to be Q9058, not Q1051. Can you fix that and then send along a PR?
Yes, I will do that.
On Mon, 14 Oct 2024 at 17:18, Andrew Tavis McAllister < @.***> wrote:
You used the wrong language id in your query, @Otom-obhazi https://github.com/Otom-obhazi :) It needs to be Q9058, not Q1051. Can you fix that and then send along a PR?
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-Data/issues/234#issuecomment-2411708411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQTIX2DE547IGDX5MBMSBFLZ3PVGJAVCNFSM6AAAAABPKW6JBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRG4YDQNBRGE . You are receiving this because you were mentioned.Message ID: @.***>
https://github.com/scribe-org/Scribe-Data/pull/361
is this good
On Tue, 15 Oct 2024 at 10:52, Angel Osim @.***> wrote:
Yes, I will do that.
On Mon, 14 Oct 2024 at 17:18, Andrew Tavis McAllister < @.***> wrote:
You used the wrong language id in your query, @Otom-obhazi https://github.com/Otom-obhazi :) It needs to be Q9058, not Q1051. Can you fix that and then send along a PR?
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-Data/issues/234#issuecomment-2411708411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQTIX2DE547IGDX5MBMSBFLZ3PVGJAVCNFSM6AAAAABPKW6JBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRG4YDQNBRGE . You are receiving this because you were mentioned.Message ID: @.***>
https://github.com/scribe-org/Scribe-Data/pull/362
I did for adverbs.. it runs well
On Tue, 15 Oct 2024 at 11:12, Angel Osim @.***> wrote:
https://github.com/scribe-org/Scribe-Data/pull/361
is this good
On Tue, 15 Oct 2024 at 10:52, Angel Osim @.***> wrote:
Yes, I will do that.
On Mon, 14 Oct 2024 at 17:18, Andrew Tavis McAllister < @.***> wrote:
You used the wrong language id in your query, @Otom-obhazi https://github.com/Otom-obhazi :) It needs to be Q9058, not Q1051. Can you fix that and then send along a PR?
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-Data/issues/234#issuecomment-2411708411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQTIX2DE547IGDX5MBMSBFLZ3PVGJAVCNFSM6AAAAABPKW6JBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRG4YDQNBRGE . You are receiving this because you were mentioned.Message ID: @.***>
Circling back to the adjectives, @Otom-obhazi: There are a lot of forms on the adjectives that weren't returned by the query. Could you check the other adjectives queries and find one that's returning more than just the adjective, but also other forms? From there you can then edit your Slovak adjectives query to return the forms that you're seeing on the items on Wikidata. Happy to explain more if you need some help :)
Thanks, I'll check them out.
On Tue, 15 Oct 2024 at 12:00, Andrew Tavis McAllister < @.***> wrote:
Circling back to the adjectives, @Otom-obhazi https://github.com/Otom-obhazi: There are a lot of forms on the adjectives that weren't returned by the query. Could you check the other adjectives queries and find one that's returning more than just the adjective, but also other forms? From there you can then edit your Slovak adjectives query to return the forms that you're seeing on the items on Wikidata. Happy to explain more if you need some help :)
— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-Data/issues/234#issuecomment-2413569066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQTIX2DZWQG2AZTALEOBKZDZ3TYTHAVCNFSM6AAAAABPKW6JBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGU3DSMBWGY . You are receiving this because you were mentioned.Message ID: @.***>
Given the current data, this issue's all closed out. Thanks all for the work here!