Scribe-Data icon indicating copy to clipboard operation
Scribe-Data copied to clipboard

Expand Estonian data queries

Open andrewtavis opened this issue 1 year ago • 8 comments

Terms

Description

This issue would look into expanding the src/scribe_data/language_data_extraction/Estonian files with as much data as are possible from the current data on Wikidata. We can use code for getting data from other languages, and from there we can check Estonian data on Wikidata for what conjugations are available. We can then expand the query with optional selections of certain forms as is done in other SPARQL queries. The query can be tried on the Wikidata Query Service UI during development :)

Data types to include:

  • [x] Nouns
  • [x] Verbs
  • [x] Adjectives
  • [x] Adverbs
  • [x] Prepositions
  • [ ] Emoji keywords

Contribution

Happy to support via answering questions and also reviewing code once a PR has been made 😊

andrewtavis avatar Oct 03 '24 22:10 andrewtavis

Hi @andrewtavis I'm interested in this. I will also like the create an issue for polish adjective extraction query

Ekikereabasi-Nk avatar Oct 05 '24 19:10 Ekikereabasi-Nk

Yes to working on this, and by all means make any issue you see as being needed, @Ekikereabasi-Nk! 😊

andrewtavis avatar Oct 06 '24 13:10 andrewtavis

Just added a list of data types that we want to include to this issue :) Have marked those that are already done or have PRs open, and we can work on the others 😊 If the data type can't work, then we can move to the others and open up specific issues later :)

andrewtavis avatar Oct 09 '24 08:10 andrewtavis

Alright @andrewtavis sorry for the delay on the estonian verbs, I had problem with git (rebase and conflict), had to do some more learning online to grab the concept properly

Ekikereabasi-Nk avatar Oct 09 '24 10:10 Ekikereabasi-Nk

No stress, @Ekikereabasi-Nk!

andrewtavis avatar Oct 09 '24 11:10 andrewtavis

Ok, @Ekikereabasi-Nk :) So, for the verbs query here I've mapped out sections that would be good to split things into. This query will likely also need to be split into other files, but my suggestion would be to write the whole thing and then split it. I can also assist more here, but if you'd like to work on the verbs query more you'd be welcome to!

andrewtavis avatar Oct 09 '24 21:10 andrewtavis

Let's take what we've learned from the recent PRs and move on to verbs, @Ekikereabasi-Nk :) One thing, please pull the changes of main from time to time. I'm realizing that your branch is behind main, and it means that when I'm in your branch I can't check what the others have done.

andrewtavis avatar Oct 10 '24 19:10 andrewtavis

Thank you @andrewtavis.

Ekikereabasi-Nk avatar Oct 11 '24 07:10 Ekikereabasi-Nk

The verbs query still needs work here, but for now I think we're fine to close this and expand it later as needed by users. Thanks, @Ekikereabasi-Nk!

andrewtavis avatar Oct 24 '24 13:10 andrewtavis