Scribe-Android icon indicating copy to clipboard operation
Scribe-Android copied to clipboard

Published 20 hours ago • verified publisher icon scribe-org

Add border to the keyboard keys

Open andrewtavis opened this issue 3 years ago • 8 comments
trafficstars

Terms

Description

This issue is to add a border to keyboard keys. The location of the keys will be more apparent and the overall look of Scribe-Android will be improved by adding them.

Help on this would be much appreciated!

andrewtavis avatar May 19 '22 14:05 andrewtavis

Hello! I am new to open source and want to participate in Hacktoberfest. I would like to work on this issue.

Cheers Iuna

IunaIuna avatar Oct 01 '22 18:10 IunaIuna

Hi @IunaIuna! Welcome to open-source! 😊 Didn't know about Hacktoberfest myself until you and a contributor for iOS mentioned it. This is really great!

I'd be happy to assign this to you and give support as I can. Feel free to reach out with questions :)

All the best!

andrewtavis avatar Oct 01 '22 21:10 andrewtavis

A quick note, @IunaIuna, I've just finished up #22, which changed the codebase a ton as lots of files got removed and moved around. Would be good for you to do a pull of the most recent version 😊

Let me know if you're hitting any roadblocks :)

andrewtavis avatar Oct 02 '22 18:10 andrewtavis

Hi! Thanks for letting me know. just synced the fork. I'm currently trying to find out where the xml defining the keyboard is located (never worked on any custom keyboards before).

IunaIuna avatar Oct 02 '22 20:10 IunaIuna

Great :) There were a few changes in the hour before you synced, so I'm glad I was able to get those in before 😊

As for as the .xml is concerned, I'm not sure if that'll be necessary for this issue. The keys are all put in programmatically based on dimensions of the screen. I'm going to bed now, but I'll check in tomorrow and see if I can direct you to where the change should happen 😊

andrewtavis avatar Oct 02 '22 22:10 andrewtavis

Morning! ☀️

Looking into it all, the Keys class in MyKeyboard.kt would be a good place to start, as well as this part of KeyboardView.kt where the backgrounds of keys are set (the commented out part is some attempts I made earlier to work on this during a hackathon 😊).

As an aside, sorry that there's not as many comments in all of this as there should be. I'm working off of a base keyboard project, and will be using #18 to go through and improve the readability :)

andrewtavis avatar Oct 03 '22 08:10 andrewtavis

@IunaIuna @andrewtavis Are you still working on this? If not can I be assigned this?

ayushanand308 avatar Feb 25 '23 22:02 ayushanand308

@ayushanand308, you'd be welcome to work on this :) I'd be happy to reassign to you in a few days if @IunaIuna has no issues with it 😊

Thanks for reaching out!

andrewtavis avatar Feb 26 '23 12:02 andrewtavis

Closed by @angrezichatterbox in #35 :) Thanks for working on this! Great to have someone working more consistently on Scribe-Android :)

andrewtavis avatar Jun 29 '24 21:06 andrewtavis