Scribe-Android icon indicating copy to clipboard operation
Scribe-Android copied to clipboard

Fix some small detekt issues

Open DeKaN opened this issue 1 year ago • 3 comments

Contributor checklist


Description

This PR fixes three small detekt problems mentioned in the issues

Related issue

  • #97
  • #100
  • #128

DeKaN avatar Oct 07 '24 22:10 DeKaN

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • [x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • [x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • [x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

github-actions[bot] avatar Oct 07 '24 22:10 github-actions[bot]

@andrewtavis two of these three detekt problems are too small, so I've combined them into one PR

DeKaN avatar Oct 07 '24 22:10 DeKaN

Totally fine, @DeKaN! Looking forward to closing all those issues in a row after this is merged!

andrewtavis avatar Oct 07 '24 22:10 andrewtavis