Scribe-Android icon indicating copy to clipboard operation
Scribe-Android copied to clipboard

App hints need to be added in for Installation, Settings and About

Open angrezichatterbox opened this issue 1 year ago • 4 comments

Terms

Description

In Scribe-iOS there are app hints present in the Installation, Settings, and About Pages. These are used to give information about the specific page used in the app and what would be the basic functionalities present on the specific page. The issue is to add these to the Scribe-Android project for the 3 pages as mentioned above for Scribe-iOS.

These should be present for the user on the first launch and then not on screen after the user clicks ok

Image references are given below:

Settings Installation About
Image 1 Image 2 Image 3

Contribution

I am happy to work on this and am more than willing to help anyone solve this issue by providing more details about the functionality.

angrezichatterbox avatar Oct 02 '24 12:10 angrezichatterbox

Hi @henrikth93. Sorry to bother you, but I wanted to ask if I could try working on this issue. The one I chose earlier is currently blocked, and for my university assignment, I need to solve a non-trivial task. Thanks.

ZayJackPrvy avatar Oct 05 '24 08:10 ZayJackPrvy

university That is absolutely fine! I will see if I can assign you to it.

henrikth93 avatar Oct 05 '24 09:10 henrikth93

university That is absolutely fine! I will see if I can assign you to it.

You have now been assigned! :)

henrikth93 avatar Oct 05 '24 09:10 henrikth93

Thanks for the reassign @henrikth93, and sorry that this slipped my mind, @ZayJackPrvy. We have an internship program starting right now and there's lots to do, but we'll be able to support and review.

CC @angrezichatterbox for support on this to make sure that @ZayJackPrvy can get things finished in time :)

andrewtavis avatar Oct 05 '24 10:10 andrewtavis

Hi @andrewtavis @henrikth93 I’ve created a hint_layout.xml for displaying hints, and I’ve also implemented the hint reset functionality #167 . However, I’m facing an issue with where exactly to place the hint_layout.xml bar.

In MainFragment, I placed it on binding.root, but it covers the entire screen. In SettingsFragment, I placed it on binding.settingsHolder because I encountered an error stating that a ScrollView can only have one child. When I placed it in settingsHolder, the hint appeared at the bottom of the screen, same isssue with hint in AboutFragment.

Could you provide some guidance on where to place the hint bar properly in these fragments? image image image

ZayJackPrvy avatar Oct 11 '24 19:10 ZayJackPrvy

CC @angrezichatterbox for support here :) Thanks for taking this on, @ZayJackPrvy! @angrezichatterbox will know best how to solve this 😊

andrewtavis avatar Oct 12 '24 00:10 andrewtavis

Could you implement this in activity_main.xml and create a function in the main activity to enable and disable it? You can then call this function from the other fragments, similar to how the Action Bar margin is adjusted based on the current page. Its function is implemented in the main and called from other fragments.

You could put a layout constraint for the view pager in the activity_main.xml to be below the hint.

angrezichatterbox avatar Oct 12 '24 05:10 angrezichatterbox

@andrewtavis I didn't link #166 and #167 to the last pull request, so both of them are still open. I appreciate the opportunity to be a part of this project. :)

ZayJackPrvy avatar Oct 13 '24 14:10 ZayJackPrvy

Thanks so much for the reminder, @ZayJackPrvy! Awesome :) You're a very welcome member of this project 😊 Hope to work with you again soon!

andrewtavis avatar Oct 13 '24 15:10 andrewtavis