Scribe-Android icon indicating copy to clipboard operation
Scribe-Android copied to clipboard

Add in the small divider line between About options and Settings options without a description

Open angrezichatterbox opened this issue 1 year ago • 4 comments

Terms

Description

In Scribe-iOS there is a small line that separates the different items in the Table View when there is no description. This can be seen in the image given below.

Screenshot 2024-09-22 at 10 54 54 AM

Currently, Scribe-Android does not separate the items in the Recycler View using a line when there is no description. This issue aims to add a line between items in a recycler view when there is no description.

Screenshot 2024-09-22 at 10 56 36 AM

Contribution

I would love to work on this and am more than willing to help anyone fix this issue :)

angrezichatterbox avatar Sep 22 '24 05:09 angrezichatterbox

can you assign this to me ?

MostafaMohamed2002 avatar Oct 04 '24 13:10 MostafaMohamed2002

Feel free to work on this issue. In case of doubts don't hesitate to ask us. Thanks :)

angrezichatterbox avatar Oct 04 '24 13:10 angrezichatterbox

is this screenshot from settings fragment , after installing the keyboard ? @angrezichatterbox @andrewtavis image

MostafaMohamed2002 avatar Oct 07 '24 14:10 MostafaMohamed2002

That or the language of the application, @MostafaMohamed2002 :) Each should have a divider.

andrewtavis avatar Oct 07 '24 15:10 andrewtavis

should i make a pull request ?🤨 @andrewtavis @angrezichatterbox

image image

MostafaMohamed2002 avatar Oct 09 '24 17:10 MostafaMohamed2002

I'm kind of assuming that the differences in the pixel heights are maybe from the emulator, @MostafaMohamed2002? Aside from this, what's the color? If it's the text color, then it'd be great if it'd be the special text color that we use for the icon :) Can't tell exactly from the images.

andrewtavis avatar Oct 09 '24 17:10 andrewtavis

i will open a pr so we can dicuss more clearly

MostafaMohamed2002 avatar Oct 09 '24 17:10 MostafaMohamed2002