Sheridan C Rawlins
Sheridan C Rawlins
scalatest has a nice check() method - is there a nice way convert/wrap a Properties in a Prop that checks all properties in the group? What was the compelling reason...
@PeteyPabPro - it seems that your observation is correct - neither JsonFormat nor JsonJacksonFormat seem to slurp the unknown fields into the Builder/Message as they could/should. I wrote a simple...
Hmm… I was just looking at JsonFormat vs. JsonJacksonFormat and found that they are different :frowning: This might not be a problem if you always used the same one on...
Good questions - I acknowledge that my observation didn't give opinion on next steps, so let me think a moment. I think we need to understand & document if possible...
Is it possible to alter/choose the behavior? I appreciate the feature, but would much prefer making what is desired possible rather than changing the default. Also, can you add a...
Please update https://github.com/bivas/protobuf-java-format/blob/master/RELEASE-NOTES.md for this fix in 1.5.
Would you mind fixing the issue you pointed out in Issue #35 ? https://github.com/bivas/protobuf-java-format/blob/master/src/main/java/com/googlecode/protobuf/format/ProtobufFormatter.java#L91 Basically, Convert this to ``` return new String(out.getBytes(), defaultCharset); ```
So sorry, but recent RELEASE-NOTES change for #37 collide with yours… please resolve the conflicts and upload.
I'm curious whether the fasterxml (Jackson) based formatter has the same issue… We should add unit tests for both for this.
You're going to have to include your protobuf too - I can't make a unit test that fails without your change.