Scott Robertson

Results 48 comments of Scott Robertson
trafficstars

I feel that we should leave that choice up to the user. If we don't have any >5.3 specific code, then we should not require it in my opinion.

@ramirovjr the develop branch is about 3 years out of date, it should really be removed. Can you retarget this at master?

That is basically exactly how we have implemented connection_pool. If the driver raises one of the errors in `is_connection_error_exception` then we shutdown the pool, and a new one is connected...

Just an update on this. We put our basic implementation into production about 2 weeks ago, and it's been working very well for us. We have had very few connection...

@meenie hey. This is basically what we are doing: https://github.com/Baremetrics/nobrainer/blob/8c30f57a6252cbffc75730fb93a3f993d61f89ba/lib/no_brainer/query_runner/driver.rb#L4-L9 And the `RDB::Pool` is essentially this https://gist.github.com/scottrobertson/390792a5ed76a64d07ff7ab9ab028249 There will be a cleaner way to do this, but it works well...

> Sorry for coming so late on this one, but I'd like to know if you have any code to implement this feature in this gem? We stopped using Rethink...

@zedtux feel free to reopen it if you want. I've not used this in a long time and I just closed all my stale/inactive issues in bulk.