container-common-scripts

container-common-scripts copied to clipboard

Distgen does different stuff when called several times

1

This is quite suspicious, that calling distgen few times in a row results in different output every time. I smell timestamps on files might be the cause here. ``` (python36-tools)...

hhorak

Easier debugging ideas

5

Brain dump of some ideas how to make the debugging easier: * print docker/podman version at the beginning of the test (plus some other related packages) * do some performance...

hhorak

The test for the PostgreSQL container includes a nice function `add_cleanup_command` that allows to extend the default `cleanup` action. It would be good to have this function in the `test-lib.sh`...

hhorak

Find Umask issue soon

6

With umask set to 077, the image build and test might fail. While we might not fix this properly, it would be good to find out that the umask is...

hhorak

openshift tests ignored when run-test is a dangling symlink

1

We should not only test whether the file exists but also if it is a symlink in case it fails the `-e` test. https://github.com/sclorg/container-common-scripts/blob/master/test.sh#L23

pkubatrh

praiskup

Avoid the `Dockerfile.rhel7` file, and use just `Dockerfile` if distgen is used

3

There are ugly hacks in the distgen logic related to `*.rhel7` lsuffix (e.g. #75 fights with that), but there's no easy way to drop the old layout because it is...

praiskup

avoid the 'sleep N' race conditions

2

E.g. #65, #62. Basically, OpenShift isn't providing enough API for avoiding such hacks, but that should at least be discussed with openshift upstream so we know how to do proper...

praiskup

.. so it looks like the rc was scaled up to 2: https://ci.centos.org/job/SCLo-container-postgresql-rh-openshift/43/consoleText

praiskup

... until the IP is available?

praiskup