python-bibtexparser icon indicating copy to clipboard operation
python-bibtexparser copied to clipboard

[WIP] bwriter: protection uppercase

Open sciunto opened this issue 9 years ago • 6 comments
trafficstars

  • [ ] doc
  • [x] list of fields
  • [ ] enhance test
  • [ ] one test skipped

sciunto avatar Apr 08 '16 18:04 sciunto

Coverage Status

Coverage decreased (-0.8%) to 94.178% when pulling 1e370b3518aeb9327d23297e536636af66353da1 on sciunto:protect_upper_case into f2893dd5b858c8eccdcbd9dad21141551734dcea on sciunto-org:master.

coveralls avatar Apr 10 '16 19:04 coveralls

@sciunto Can I ask you to give me some background on this PR? I can try to have a look and finish it if you think this is important before tagging 0.7.0. Thanks!

Phyks avatar Jul 11 '17 20:07 Phyks

The point is that fields like titles may have upper case letters, intended to be printed like that. But, for that, it needs to be protected with braces {}. Often, editors do not do a proper work on that.

This should not block the next release though. It's an enhancement. Targeting to 0.8.0 is ok for me.

sciunto avatar Jul 13 '17 11:07 sciunto

I'ld like to take care of this feature 🥳 (as I'm also interested in this feature for my own Python-BibTex-Handler).

@MiWeiss what do you think about the option:

# A list of fields for which to preserve the upper case, i.e. wrapping the field value with another pair of curly braces. For example: title = {{Preserve Upper Case}}
self.protect_upper_case: List[str] = []

michaelfruth avatar Sep 08 '22 22:09 michaelfruth

Hi @michaelfruth

Thanks again (and again :-) ) for your great effort. My answer here equally goes for #244.

In the background, I've been working on preparing python-bibtexparser v2.0, which is a complete re-write of the library, fixing several of its structural issues (error handling, performance and encoding issues to name a few). While I'll be able to take over your previous PRs pretty much unchanged into the new codebase, for what regards #244 and #126 that's probably not the case and I'd hate to have you waste your time on something becoming obsolete soon anyways.

Thus, I wondered if you were interested into joining the dev of v2.0. At the moment, as I'm still laying out the overall architecture, there's no public branch yet, but if you're interested, I'd happily drop you an email with some more info.

MiWeiss avatar Sep 14 '22 04:09 MiWeiss

Hi @MiWeiss,

No problem for delayed answers, I was also very busy for the last few days ;-). I just try to contribute once I've some time.

Yes, I'ld like to join the development ov Version 2.0! 🥳 Do you invite me to the project or shall I send you my email to have some conversation there?

michaelfruth avatar Sep 14 '22 19:09 michaelfruth

close

  • stale
  • the proposed solution would probably introduce too much technical depth anyways
  • the proposed solution appears cumbersome to use; if really needed a similar thing should be feasible in v2 with a custom middleware.

MiWeiss avatar May 26 '23 14:05 MiWeiss