scikit-rf
scikit-rf copied to clipboard
scikit-rf
HP8720B driver
Hi, Here is my code to interface with a HP8720B VNA (2 ports up to 20GHz). First time making a pull request so say if I need to do anything extra. I created the code by modifying the 8510 driver as they have similar GPIB commands although certain aspects behave differently.
Currently I have commented out the compound sweep as I have not looked into how that works and this VNA can go up to 1601 points anyway. I have also found that I have not been able to communicate with the VNA using FORM4 (seems to only output the first frequency point) so have relied on the previous FORM2 code from the 8510 - which is quicker anyway. The inbuilt frequency segment sweep mode seems to work for the initial data output and then the VNA gets stuck. Currently unsure why this is.
Thanks, Leon
@cafeclimber , can you have a look please?
@leonknight99-flann there are several things that make the code not passing the linter. Can you correct them? (you can use pre-commit to test locally)
Hi, I think I have set up the pre-commit properly this time and hopefully found all the white spaces etc that I missed previously. Hope its all ok to merge this time!
@leonknight99-flann could you clean up the unused comment lines of code?
@jhillairet Sorry been on holiday for the past few weeks, will get around to clearing the code and comments up hopefully in the next couple weeks
@jhillairet Sorry been on holiday for the past few weeks, will get around to clearing the code and comments up hopefully in the next couple weeks
@leonknight99-flann could you finish this PR? to include it in the next release eventually.
@leonknight99-flann do you plan to finalize this PR?
Hi, Sorry I have not managed to finalize yet, life has gotten unexpectedly quite busy for the past few months. I still plan to finish it at some point although cannot guarantee when. Up to you if you would like to keep this open or close it and then I can reopen when I am next free to work finishing it. Thanks!
Hi, I have removed all the commented code ready for a release. As a note, this code was copied from the 8510 code so that compound sweeps would be possible. I have not had time to implement these so just removed it instead. The 8720B also has support for a native frequency segment mode which seems to achieve the same objective. Mine currently breaks after the first output so requires a hard reset of the analyser although I am not sure why this is. I have seen that with the more recent PNA example that if the VNA uses channels then a sub-class of channel should be included. I have not completed this yet as channels work differently for these older analysers anyway.
Hope it is all ok!
@leonknight99-flann could you fix the conflicts and update this PR?
Hopefully this has fixed all the conflicts? I had to manually change some of the files as I think my IDE is set up in a way that it does not like committing files with no blank space on the end. Say if I need to do anything else!
Hi, the linting comes up with this error: 'Error: skrf/calibration/tests/test_deembedding.py:576:58: W292 No newline at end of file' after I have copied that file from the main git page. Just wondering if I have an out of date lint or if something else has happened and its just been missed.
@jhillairet Hi, Just wondering if this all ok or if I need to do any further work before it is merged. Thanks, Leon
Hi, the linting comes up with this error: 'Error: skrf/calibration/tests/test_deembedding.py:576:58: W292 No newline at end of file' after I have copied that file from the main git page. Just wondering if I have an out of date lint or if something else has happened and its just been missed.
indeed, the linter still complains. I'll fix it.