forest-confidence-interval icon indicating copy to clipboard operation
forest-confidence-interval copied to clipboard

Sum taken over wrong axis

Open bchugg opened this issue 4 years ago • 2 comments

Hi there,

I believe the centered predictions are being computed incorrectly. Line 278 in forestci.py takes the average over the predictions, as opposed to the trees. The resulting shape of pred_mean is (forest.n_estimators,) when it should be (X_test.shape[0],). See below:

https://github.com/scikit-learn-contrib/forest-confidence-interval/blob/6d2a9c285b96bd415ad5ed03f37e517740a47fa2/forestci/forestci.py#L278

Thanks for the great package otherwise! :)

bchugg avatar Jun 03 '21 17:06 bchugg

are there any thoughts on this one?

nikaashpuri avatar Nov 07 '22 15:11 nikaashpuri

please check https://github.com/scikit-learn-contrib/forest-confidence-interval/issues/80

nikaashpuri avatar Nov 08 '22 02:11 nikaashpuri