scikit-image icon indicating copy to clipboard operation
scikit-image copied to clipboard

Python 3.11 wheels

Open EpicWink opened this issue 3 years ago • 3 comments

Build wheels for Python 3.11

Should be just adding cibw_python: "cp311-*" to the build-wheels CI job matrix

Note you'll likely be waiting for the Python 3.11 wheels for:

  • scipy: scipy/scipy#16851
  • astropy: https://github.com/astropy/astropy/issues?q=3.11
  • imread: luispedro/imread#41
  • matplotlib: matplotlib/matplotlib#23637
  • pywavelets: PyWavelets/pywt#649

EpicWink avatar Sep 13 '22 06:09 EpicWink

You can add cp311-cp311 to the python-versions, that PR only changes the default. However, you may need to update the version of RalfG/python-wheels-manylinux-build to the latest. See dulwich/pythonwheels.yml for an example.

skshetry avatar Sep 13 '22 08:09 skshetry

Thanks, I was planning to open a PR soon, porting the same changes I did for PyWavelets here. Aside from the small .yaml file updates, we have to update the NumPy version pinnings in our pyproject.toml to be consistent with current Values in SciPy/PyWavelets (where they were recently updated to account for Python 3.11).

I will tag the new PyWavelets release tonight or tomorrow.

For SciPy we definitely won't want it to build from source, but it looks like we can start testing from the nightly 3.11 wheels here.

grlee77 avatar Sep 14 '22 00:09 grlee77

See #6519 for progress on this.

lagru avatar Sep 20 '22 10:09 lagru

Scipy has released 3.11 wheels in their latest release.

papr avatar Oct 11 '22 13:10 papr

In progress: https://github.com/scikit-image/scikit-image/pull/6566 After this, we'll enable wheels.

stefanv avatar Oct 11 '22 19:10 stefanv

Reopening so that we have an issue tracking this request. See #6581 for the second step of the progress.

lagru avatar Oct 16 '22 09:10 lagru

FYI: imread just released their 311 wheels, so the last blocker in the original post is gone.

Erotemic avatar Nov 09 '22 16:11 Erotemic

Any updates on this? It seems like all that's left to do is make the release.

Erotemic avatar Dec 03 '22 07:12 Erotemic

Yes, @grlee77 will be working on fixing broken Windows wheels this week.

stefanv avatar Dec 03 '22 13:12 stefanv

Is there also an estimate for linux? As I tried it at the beginning of November it looked like the wheels were also broken on linux.

sebwr avatar Dec 03 '22 16:12 sebwr

I pushed an update that fixed the AMD64 Windows wheels and dropped 32-bit Windows support. The linux ones were already working aside from a couple of 32-bit ones (also dropped in that PR). See this comment and link therein: https://github.com/scikit-image/scikit-image/pull/6581#issuecomment-1336206370

edit: just remembered that all wheels were initially failing due to failure to import lazy_loader at test time, but that is also now resolved in the PR linked above

grlee77 avatar Dec 03 '22 17:12 grlee77

Can we close this now that #6581 is merged? Or should we wait until we've actually released 3.11 wheels?

lagru avatar Dec 21 '22 10:12 lagru

Is there an estimate, when the 3.11 wheels are released?

sebwr avatar Dec 21 '22 11:12 sebwr

We have been meaning to release version 0.20 a few weeks ago but it got stalled. I'm not expecting much to happen before the new year but hope that we will push a pre-release candidate soon after that. @sebwr, sorry for the wait.

lagru avatar Dec 21 '22 11:12 lagru

No hurries, Im also done for this year. Happy holidays for everyone involved.

sebwr avatar Dec 21 '22 17:12 sebwr

Any news to the v0.20 update including the 3.11 wheels?

sebwr avatar Jan 09 '23 14:01 sebwr

Hey @sebwr, we are working on a release candidate 0.20.0rc1 right now. It's currently blocked by #6667 but after that is resolved, the proper release shouldn't be far away.

lagru avatar Jan 14 '23 11:01 lagru

Are there infos for the release date?

sebwr avatar Jan 27 '23 11:01 sebwr

This appears to be an issue still. I am unable to install scikit-image in Python 3.11 on Windows.

pip install scikit-image --pre works but that also requires me to install it separately, so pip install some_downstream_package that requires scikit-image in Python 3.11 will fail.

pllim avatar Feb 15 '23 15:02 pllim

The wheels are building just fine, the pre-releases are out on PyPi, and the main release itself will be available in a week.

@pllim If --pre works, then there's nothing else to be done right now.

stefanv avatar Feb 16 '23 00:02 stefanv

@stefanv , correct, the pre-release installs fine. I see that RCs are actively being pushed. Good luck in the release!

pllim avatar Feb 16 '23 01:02 pllim

See https://pypi.org/project/scikit-image/0.20.0rc8/#files

jarrodmillman avatar Feb 21 '23 06:02 jarrodmillman

We're about to publish the next release, so I'm going to close this to clear the milestone. Thanks for your feedback, all.

stefanv avatar Feb 22 '23 20:02 stefanv