pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

[WIP] seed notebook

Open lukasheinrich opened this issue 6 years ago • 4 comments

Description

seed notebook for #545 . Can be expanded.

screenshot

Checklist Before Requesting Reviewer

  • [ ] Tests are passing
  • [ ] "WIP" removed from the title of the pull request
  • [ ] Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • [ ] Summarize commit messages into a comprehensive review of the PR

lukasheinrich avatar Sep 06 '19 11:09 lukasheinrich

Coverage Status

Coverage remained the same at 93.76% when pulling 5b67ff5e66278c57986c358a81e7e791b486ce7e on batchnotebook into 6c7baef524ca8b2a1d95e1c60ddb0f237be11a16 on master.

coveralls avatar Sep 06 '19 11:09 coveralls

Please add this to the notebook tests.

Good call. Done.

matthewfeickert avatar Sep 06 '19 18:09 matthewfeickert

E           ---------------------------------------------------------------------------
E           Exception encountered at "In [2]":
E             File "<ipython-input-2-4c36770bea61>", line 9
E               **data, batch_size = 101**2
E                     ^
E           SyntaxError: invalid syntax

lukasheinrich avatar Sep 06 '19 18:09 lukasheinrich

Codecov Report

Merging #548 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          62       62           
  Lines        3603     3603           
  Branches      521      521           
=======================================
  Hits         3500     3500           
  Misses         64       64           
  Partials       39       39           
Flag Coverage Δ
#unittests 97.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e3f729...f3c2cf5. Read the comment docs.

codecov[bot] avatar Oct 21 '20 10:10 codecov[bot]