pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

ci: Use codecov-cli for coverage report upload

Open matthewfeickert opened this issue 2 years ago • 1 comments
trafficstars

Description

Resolves #2256

Use codecov-cli to upload coverage report over codecov/codecov-action GitHub Action to be able to make future use of Codecov ATS.

  • c.f. https://docs.codecov.com/docs/the-codecov-cli

Checklist Before Requesting Reviewer

  • [ ] Tests are passing
  • [x] "WIP" removed from the title of the pull request
  • [x] Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • [x] Summarize commit messages into a comprehensive review of the PR
* Use codecov-cli to upload coverage report over codecov/codecov-action
  GitHub Action to be able to make future use of Codecov ATS.
   - c.f. https://docs.codecov.com/docs/the-codecov-cli

matthewfeickert avatar Jul 20 '23 22:07 matthewfeickert

Hm. A concern I have is that this is installing a lot of dependencies, where the GitHub Action removes that from our environment. This is what happens when it is installed in an empty Python 3.11 virtual environment.

(venv) root@1ba964ac7c35:/# python -m pip list
Package            Version
------------------ --------
anyio              3.7.1
certifi            2023.5.7
charset-normalizer 3.2.0
click              8.1.6
codecov-cli        0.1.16
coverage           7.2.7
h11                0.14.0
httpcore           0.16.3
httpx              0.23.3
idna               3.4
ijson              3.2.2
iniconfig          2.0.0
packaging          23.1
pip                23.2
pluggy             1.2.0
pytest             7.4.0
pytest-cov         3.0.0
PyYAML             6.0.1
requests           2.31.0
responses          0.21.0
rfc3986            1.5.0
setuptools         68.0.0
smart-open         6.3.0
sniffio            1.3.0
tree-sitter        0.20.1
urllib3            2.0.4
wheel              0.40.0
(venv) root@1ba964ac7c35:/#

Many of these are pinned to major or minor versions, which means that this is going to cause pain in the CI process. I think that I would prefer to avoid this and just use pipx or something if this is really necessary.

matthewfeickert avatar Jul 20 '23 22:07 matthewfeickert