pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

learn notebook for CLs asymptotics

Open lukasheinrich opened this issue 4 years ago • 4 comments

Description

produces this animation

anim

lukasheinrich avatar May 26 '21 10:05 lukasheinrich

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Codecov Report

Patch coverage has no change and project coverage change: -0.65 :warning:

Comparison is base (a28d1a3) 98.30% compared to head (3f92552) 97.65%.

:exclamation: Current head 3f92552 differs from pull request most recent head acc12fc. Consider uploading reports for the commit acc12fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   98.30%   97.65%   -0.65%     
==========================================
  Files          69       64       -5     
  Lines        4534     4008     -526     
  Branches      802      565     -237     
==========================================
- Hits         4457     3914     -543     
- Misses         45       55      +10     
- Partials       32       39       +7     
Flag Coverage Δ
contrib 25.52% <ø> (-72.36%) :arrow_down:
doctest ?
unittests 97.43% <ø> (?)
unittests-3.10 ?
unittests-3.11 ?
unittests-3.8 ?
unittests-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 54 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 26 '21 10:05 codecov[bot]

very cool. I would still suggest a transposed version of the top right plot. Maybe in the middle right panel? I'd also suggest increasing the size of the axis labels a little.

Also, recommend matplotlib -> jshtml to include in static HTML http://louistiao.me/posts/notebooks/embedding-matplotlib-animations-in-jupyter-as-interactive-javascript-widgets/

cranmer avatar May 26 '21 21:05 cranmer

ttherre is also an arrangement like tthis that has tthe CLs and the qµ distrtibutions in normal orientation and the gaussian µ^ distribution rotated

image

lukasheinrich avatar May 26 '21 22:05 lukasheinrich