fastjet icon indicating copy to clipboard operation
fastjet copied to clipboard

Published 20 hours ago • verified publisher icon scikit-hep

build: Remove manual CGAL install

Open matthewfeickert opened this issue 1 year ago • 2 comments
trafficstars

Addresses (and maybe resolves, will need to check) Issue https://github.com/scikit-hep/fastjet/issues/193.

  • build: Remove manual CGAL install

    • Remove the manual download of CGAL from setup.py.
    • Remove --with-cgaldir autogen.sh flag as CGAL should be installed in a location by the package managers or user that it is findable.

  • build: Add manual CGAL install for Linux cibuildwheel

    • The cibuildwheel Linux container is CentOS 7 based, but CGAL is not packaged for CentOS with yum — only for apt-get, Homebrew, and conda-forge. For Linux cibuildwheel builds this then requires that the CGAL headers (CGAL is header only) need to be manually downloaded from GitHub and then copied into /usr/include/.

  • docs: Add libcgal-dev install to README

    • Add libcgal-dev to the required packages to install for Linux based development.

  • ci: Add cgal install to CI

    • Use package managers to install libcgal-dev (Linux) and cgal (macOS) in CI jobs.

matthewfeickert avatar Sep 13 '24 05:09 matthewfeickert

This is ready for review. On my fork I also manually started a wheels build to verify that everything passed across all wheels. (Linux aarch64 jobs take a long time due to emulation — c.f. https://github.com/scikit-hep/boost-histogram/issues/958, which is related but not the main time sink.)

image

matthewfeickert avatar Sep 13 '24 06:09 matthewfeickert

Putting into draft state until PR https://github.com/scikit-hep/fastjet/pull/319 is merged or closed.

matthewfeickert avatar Sep 17 '24 08:09 matthewfeickert

Closed by #342

lgray avatar Jun 10 '25 19:06 lgray