feat: Array Builder in Numba - add missing methods
Address Issue #1438: ArrayBuilder in Numba is missing some methods, such as 'string'
Codecov Report
Merging #1677 (c00f636) into main (38243b2) will increase coverage by
0.02%. The diff coverage is87.36%.
Additional details and impacted files
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/awkward/_connect/numba/layout.py | 84.87% <ø> (ø) |
|
| src/awkward/_connect/numba/builder.py | 82.79% <87.09%> (+1.18%) |
:arrow_up: |
| src/awkward/_connect/numba/arrayview.py | 97.77% <100.00%> (ø) |
|
| src/awkward/contents/indexedarray.py | 79.46% <0.00%> (-0.20%) |
:arrow_down: |
| src/awkward/contents/recordarray.py | 83.72% <0.00%> (-0.18%) |
:arrow_down: |
| src/awkward/_util.py | 82.36% <0.00%> (-0.18%) |
:arrow_down: |
| src/awkward/contents/indexedoptionarray.py | 88.90% <0.00%> (-0.16%) |
:arrow_down: |
| src/awkward/_connect/avro.py | 87.17% <0.00%> (-0.14%) |
:arrow_down: |
| src/awkward/types/_awkward_datashape_parser.py | 47.72% <0.00%> (-0.01%) |
:arrow_down: |
| src/awkward/contents/content.py | 77.31% <0.00%> (+0.10%) |
:arrow_up: |
@ianna I've squashed your commits and rebased them onto main in https://github.com/scikit-hep/awkward/tree/agoose77/rebase-numba-array-builder if you're happy to force push them here. I should have preserved you as the author of those commits :)
@agoose77 - do I understand correctly that some jobs get cancelled because the other architectures fail?
All "matrix-jobs" (e.g. py36, py37, ...) within the same top-level job, (e.g. Linux), will be canceled if a single matrix job fails, yes. :)
If you need to turn off the fail-fast for diagnostic purposes, you can do that by changing the .github/workflows YAML in your branch—it will be fail-slow in just your branch. Just don't forget to revert it.
I added a task to this PR so that we don't forget to restore the CI configuration :)