scikit-build-core icon indicating copy to clipboard operation
scikit-build-core copied to clipboard

Published 20 hours ago • verified publisher icon scikit-build

About `madebr/python-cmake-file-api`

Open LecrisUT opened this issue 2 years ago • 3 comments

I got informed about another project that is implementing cmake file-api for python: madebr/python-cmake-file-api. What do you think @henryiii?

LecrisUT avatar Jul 31 '23 09:07 LecrisUT

I think our implementation is much cleaner! See https://github.com/scikit-build/scikit-build-core/blob/main/src/scikit_build_core/file_api/model/codemodel.py for example, compared to https://github.com/madebr/python-cmake-file-api/blob/master/cmake_file_api/kinds/codemodel/v2.py

henryiii avatar Aug 01 '23 13:08 henryiii

Indeed it looks much cleaner. But then what would be the plans to share this outside of the sk-build-core? It would be unintuitive for the user to import a build tool to access cmake file api. Otherwise, the only thing that would missing is to make the api be stateful.

LecrisUT avatar Aug 14 '23 12:08 LecrisUT

user to import a build tool to access cmake file api

Given you have to trigger a config run to get the file API, I don't think it's that unreasonable to have it inside a build tool. Biggest issues currently are not many tests and no documentation.

I think stateful queries would be pretty trivial to add.

henryiii avatar Aug 15 '23 16:08 henryiii