php-code-analysis icon indicating copy to clipboard operation
php-code-analysis copied to clipboard

Errort whilst whilst analysing deps

Open michaelcullum opened this issue 12 years ago • 3 comments
trafficstars

http://jmsyst.com/reviews/ba4b0121-f8f1-4e79-8fbc-dcf430f3fbb8

It seems like there was an unrecoverable error when analyzing your dependencies. This could be a problem with your composer.json, but might also be an internal error.

michaelcullum avatar Jan 18 '13 13:01 michaelcullum

Thanks for reporting.

The problem is caused by a dependency of yours which has a type object<Sonata\AdminBundle\Model\ModelManagerInterface;>. Note the ending ";" which is causing some parser to fail.

I've added a patch to handle such a situation more gracefully, but since the service will transition to a new website soon, there will probably be no other deployment for the current website. I'll keep you informed.

schmittjoh avatar Jan 18 '13 13:01 schmittjoh

Perhaps adding some more specific errors to end users when things fail? Prevents having to submit tickets every time?

michaelcullum avatar Jan 18 '13 13:01 michaelcullum

Yeah, indeed.

The new website should have improved logging already, and it should be generally easier to expand it given its new architecture.

schmittjoh avatar Jan 18 '13 13:01 schmittjoh