Code review failing for reasons unknown

[michaelcullum]

trafficstars

http://jmsyst.com/reviews/1483cb73-a6c7-4229-ab8d-0ef6c725d897

Not quite sure why it keeps failing.

[michaelcullum]

Same for http://jmsyst.com/reviews/091c531c-9740-4341-8155-22ebd97b6de1

[schmittjoh]

It seems like Swiftmailer fails when it tries to send you an email (there is a space too much at the end).

I'll add a trim in the next deployment, but would be cool if you could manually change it, and verify that it works then.

On Sun, Nov 18, 2012 at 8:11 PM, Michael C. [email protected]:

Same for http://jmsyst.com/reviews/091c531c-9740-4341-8155-22ebd97b6de1

— Reply to this email directly or view it on GitHubhttps://github.com/schmittjoh/php-code-analysis/issues/35#issuecomment-10489961.

[michaelcullum]

At the end of what?

[schmittjoh]

The email address: [email protected]\s

This could also be a \r if you have Mac line endings by any chance? Anyway, will deploy a fix for it soon.

[michaelcullum]

Not sure where it is trying to send an email? I haven't touched swiftmailer on it yet. And me and the other person working on it have UNIX line endings so not sure how that happened.

[schmittjoh]

No, it's not in your code. It's one of the notification emails that you have configured (one has a space, or another whitespace character at the end).

[michaelcullum]

Oh right. Thanks.

[michaelcullum]

Is there a way to force an instant code review?

[stof]

@unknownbliss There is a button to schedule a full review

[michaelcullum]

Not quite sure how I missed that. Thanks.

[michaelcullum]

Works, thanks.