JMSI18nRoutingBundle icon indicating copy to clipboard operation
JMSI18nRoutingBundle copied to clipboard

Better language detection and validation

Open johannes85 opened this issue 13 years ago • 4 comments

Correct me if i'm wrong but shouldn't the hl parameter in the cookie and request be validatet against the available locales ?

And i also extended the browser language detechtion by splitting the language from the country if both are set.

johannes85 avatar Jul 20 '12 08:07 johannes85

Sounds good.

Could you please add tests, and also check the CS of your patch?

schmittjoh avatar Jul 20 '12 09:07 schmittjoh

At the moment i haven't the time i try to squeeze this in sometime.

johannes85 avatar Jul 25 '12 06:07 johannes85

This should really be merged... Its very broken otherwise. I've started to fix a couple of the other unit tests, however a number more need to be fixed up.

ajohnstone avatar Apr 02 '13 14:04 ajohnstone

+1 but patch looks not so good :(

ASKozienko avatar Apr 25 '14 11:04 ASKozienko