dosbox-pure icon indicating copy to clipboard operation
dosbox-pure copied to clipboard

Published 20 hours ago • verified publisher icon schellingb

Directrories with extensions

Open lbrpdx opened this issue 3 years ago • 2 comments
trafficstars

Maybe I'm doing things wrong, but I'm trying to load a game from the command line, and I expect to get the start menu if I don't have any dosbox.bat file or equivalent to be launched automatically. I'm using Linux, on an ext4 file system to host my games (if that is of any importance).

  • When the game folder is called robocop for example: I launch it as an argument through the retroarch command line and on start-up I correctly have the start menu and can select any ROBOCOP.EXE or ROBOCOP.COM in that list. All good.
  • If I rename the folder to robocop.pc, I get "No executable file found" on the start menu. That's my issue, I would expect to see the .EXE and .COM files listed here, for directories that have extensions on my Linux filesystem.
  • What is weird is: if I load the upper directory where my robocop.pc folder is located (for example with /userdata/roms/dos/robocop.pc, if I load /userdata/roms/dos/ from the retroarch command line) I can correctly see all the sub-directories in the start menu, including ROBOCOP.PC\ROBOCOP.COM and ROBOCOP.PC\ROBOCOP.EXE.

My retroarch command line: /usr/bin/retroarch -L /usr/lib/libretro/dosbox_pure_libretro.so --config /userdata/system/configs/retroarch/retroarchcustom.cfg /userdata/roms/dos/robocop.pc

lbrpdx avatar Sep 01 '22 23:09 lbrpdx

While it's not possible with the RetroArch user interface to run to the core with a directory, I recently realized that it is possible with the command line and made it so it at least doesn't crash anymore. But as of now the distinction between directory and file is only done by checking if a dot is found in the name. We could attempt to use anything with an unrecognized file extension as a directory but then someone might have a directory named "game.zip" so I guess to properly handle this we need to ask the file system if the passed path is a file or a directory before doing anything.

schellingb avatar Sep 18 '22 19:09 schellingb

Maybe define a list of acceptable directory extensions like .dir. and .pc... Of course if someone creates a directory ending up in .zip or .exe, they will run into trouble... but that's not entirely unexpected.

lbrpdx avatar Sep 20 '22 22:09 lbrpdx

This has been fixed in #382 which is now in the latest 0.9.8 release.

schellingb avatar Dec 20 '23 16:12 schellingb