create-scandipwa-app icon indicating copy to clipboard operation
create-scandipwa-app copied to clipboard

Namespaces for arrow functions are generated non-exclusively

Open alfredsgenkins opened this issue 4 years ago • 2 comments

Describe the bug

The namespace generated for arrow functions of then handler do not generate namespaces correctly.

image

alfredsgenkins avatar Jan 25 '21 10:01 alfredsgenkins

I can propose several solutions to this issue:

  1. Less backwards-compatible, more straightforward image

  2. More backwards-compatible, less straightforward image

Since we don't have many plugins for v4 now, we can allow breaking changes to some extent. What do you think?

yeegor avatar Feb 02 '21 08:02 yeegor

I prefer first option, while the question is what is that all keyword appearing in the code? Are there other potentially breaking cases, except then? Probably, there are. In that case, maybe we should add one, two, etc. (or first, second, ...) (or 1, 2, ...) to arguments? Otherwise we must handle each case separately.

alfredsgenkins avatar Feb 02 '21 10:02 alfredsgenkins