Sergio Cambra

Results 144 comments of Sergio Cambra

I have same issue using passenger, not puma. I wasn't using release_connection and with_connection, and it happened too often, when I added release_connection and with_connection to the action using response.stream,...

I'm using MySQL, and no problem since wrapping with thread the action which uses response.stream. I didn't wrap other actions with thread, but I don't have problem anyway, maybe because...

I got issue, not so often as previously. I finally created a new controller for live actions, so every action is wrapped with release_connection, new thread, with_connection. I didn't have...

I think you shouldn't unvendor some libs which were changed in Watcher3, check the changes: https://github.com/barbequesauce/Watcher3/blob/master/lib/mods.txt I think PTN got many changes, I would like to replace it with something...

About PTN, another way to unbundle it would be creating a fork and pushing our changes there.

@labrys agree with you, I don't like vendoring, I had to upgrade some lib and it's a pain. Although I think vendoring PTN is ok as it's not maintained, and...

I agree, I wanted to fork PTN and push the changes, but I had no time yesterday

@labrys Can you change parse-torrent-name with [parse-torrent-title](https://github.com/platelminto/parse-torrent-title)? Then we should work in a branch to adapt our code to the new fields in PTN

The code is quite different. Our vendored lib was patched to parse edition, and parse-torrent-title has no edition parsing I think, but I don't know how important is, but parse-torrent-title...

The latest commit removed all changes applied to our vendored lib, as I warn @barbequesauce. Edition is still used in our code: ``` core/library.py: 'edition': [] core/library.py: data['edition'].append('3D') core/library.py: data['edition']...