webknossos icon indicating copy to clipboard operation
webknossos copied to clipboard

Bump default docker tags in hosting webknossos==24.06.0, fossildb==master__489 for latest release

Open aaronkanzer opened this issue 1 year ago • 3 comments

Just a PR for clarity when deploying WebKNOSSOS locally based off of last released changelog https://github.com/scalableminds/webknossos/blob/7b95132dfa46d8c6a5a07e90830bf6144291918e/CHANGELOG.released.md?plain=1#L10

I noticed the discrepancy when I had initially installed 24.04.0, then bumped the version in Docker with a forked version of 24.06.0, thus seeing discrepancies.

Also, bumped compatible fossildb tag as well

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • abc

TODOs:

  • [ ] ...

Issues:

  • fixes #

(Please delete unneeded items, merge only when none are left open)

  • [ ] Updated changelog
  • [ ] Updated migration guide if applicable
  • [ ] Updated documentation if applicable
  • [ ] Adapted wk-libs python client if relevant API parts change
  • [ ] Removed dev-only changes like prints and application.conf edits
  • [ ] Considered common edge cases
  • [ ] Needs datastore update after deployment

aaronkanzer avatar Jun 13 '24 20:06 aaronkanzer

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Aaron Kanzer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 13 '24 20:06 CLAassistant

Also -- I signed https://github.com/scalableminds/webknossos/pull/7881#issuecomment-2166692706 but it did not register correctly apparently (under my email [email protected])

aaronkanzer avatar Jun 13 '24 20:06 aaronkanzer

Hi Aaron, thanks a lot for your contribution.

To merge your changes into our master, we need you to sign the CLA properly. Apparently, it is not working because you have not added the email address with which you configured your local git to "sign" commits. This can be seen by your icon not appearing left to the commit message in this PR (compared to Norman's commit just now)

You can get this email address by executing git config user.email in your CLI. Then please add this email address to your GitHub account. A how-to is linked there (I think)

Aaron Kanzer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Hopefully, everything should work then.

MichaelBuessemeyer avatar Jun 19 '24 08:06 MichaelBuessemeyer

Closing this PR since its contents are now supserseded by https://github.com/scalableminds/webknossos/pull/8287. Still, thanks for your contribution and sorry about the CLA hassle

fm3 avatar Dec 21 '24 18:12 fm3